-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage generic persistence event classes #9633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Apr 6, 2022
derrabus
force-pushed
the
types/generic-events
branch
from
April 10, 2022 21:48
b018ef7
to
5d7153f
Compare
greg0ire
approved these changes
Apr 11, 2022
Either we release 2.12.0 now or this should be retargeted to 2.11.x, as it fixes the build |
The build on 2.11.x has been fixed by #9648 already. |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 11, 2022
* 2.12.x: Leverage generic persistence event classes (doctrine#9633) Fix static analysis for Persistence 2.5 (doctrine#9648) Improve exception message (doctrine#9646) Deprecate console helper (doctrine#9641) Use charset/collation from column or table default when creating relations (doctrine#9636) Support Enum IDs and search by Enum fields (doctrine#9629) Fix composer install in contributing readme
Still getting Psalm errors
|
You did upgrade to Persistence 2.5? |
|
Okay, but the CI job is green. Something must be off on your side. https://github.com/doctrine/orm/runs/5970318458?check_suite_focus=true |
Yea, seems some cache issue.
Fixed it. Sorry for wasting your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows doctrine/persistence#273